Step 661: pilot queue panel model

This commit is contained in:
Bill
2026-02-17 22:15:13 -07:00
parent 782af1a77f
commit 8c178644a6
4 changed files with 96 additions and 0 deletions

View File

@@ -4828,4 +4828,13 @@ target_link_libraries(step660_test PRIVATE
tree_sitter_javascript tree_sitter_typescript
tree_sitter_java tree_sitter_rust tree_sitter_go)
add_executable(step661_test tests/step661_test.cpp)
target_include_directories(step661_test PRIVATE src)
target_link_libraries(step661_test PRIVATE
nlohmann_json::nlohmann_json
unofficial::tree-sitter::tree-sitter
tree_sitter_python tree_sitter_cpp tree_sitter_elisp
tree_sitter_javascript tree_sitter_typescript
tree_sitter_java tree_sitter_rust tree_sitter_go)
# Step 12: Dear ImGui shell scaffolding created (main.cpp exists but not built due to dependencies)

View File

@@ -0,0 +1,39 @@
#pragma once
// Step 661: Pilot queue panel model
#include <string>
#include <vector>
enum class PilotDecision { Pending, Approved, Rejected, Modified };
struct PilotQueueItem {
std::string jobId;
std::string summary;
bool escalate = false;
double ambiguity = 0.0;
PilotDecision decision = PilotDecision::Pending;
std::string strategyNote;
};
class PilotQueuePanelModel {
public:
static bool needsHumanReview(const PilotQueueItem& item, double threshold = 0.5) {
return item.escalate || item.ambiguity > threshold;
}
static void approve(PilotQueueItem* item) {
if (!item) return;
item->decision = PilotDecision::Approved;
}
static void reject(PilotQueueItem* item) {
if (!item) return;
item->decision = PilotDecision::Rejected;
}
static void modify(PilotQueueItem* item, const std::string& note) {
if (!item) return;
item->decision = PilotDecision::Modified;
item->strategyNote = note;
}
};

View File

@@ -0,0 +1,24 @@
// Step 661: Pilot queue panel (12 tests)
#include "PilotQueuePanelModel.h"
#include <iostream>
static int p=0,f=0;
#define T(n) { std::cout<<" "<<#n<<"... "; }
#define P() { std::cout<<"PASS\n"; ++p; }
#define F(m) { std::cout<<"FAIL: "<<m<<"\n"; ++f; }
#define C(c,m) if(!(c)){F(m);return;}
void t1(){T(needs_review_when_escalate_true);PilotQueueItem i{"j","s",true,0.1};C(PilotQueuePanelModel::needsHumanReview(i),"review");P();}
void t2(){T(needs_review_when_ambiguity_above_threshold);PilotQueueItem i{"j","s",false,0.8};C(PilotQueuePanelModel::needsHumanReview(i),"review");P();}
void t3(){T(no_review_when_below_threshold_and_not_escalated);PilotQueueItem i{"j","s",false,0.2};C(!PilotQueuePanelModel::needsHumanReview(i),"no review");P();}
void t4(){T(approve_sets_decision);PilotQueueItem i;PilotQueuePanelModel::approve(&i);C(i.decision==PilotDecision::Approved,"approve");P();}
void t5(){T(reject_sets_decision);PilotQueueItem i;PilotQueuePanelModel::reject(&i);C(i.decision==PilotDecision::Rejected,"reject");P();}
void t6(){T(modify_sets_decision);PilotQueueItem i;PilotQueuePanelModel::modify(&i,"note");C(i.decision==PilotDecision::Modified,"modify");P();}
void t7(){T(modify_sets_strategy_note);PilotQueueItem i;PilotQueuePanelModel::modify(&i,"use safer path");C(i.strategyNote=="use safer path","note");P();}
void t8(){T(approve_handles_null);PilotQueuePanelModel::approve(nullptr);P();}
void t9(){T(reject_handles_null);PilotQueuePanelModel::reject(nullptr);P();}
void t10(){T(modify_handles_null);PilotQueuePanelModel::modify(nullptr,"x");P();}
void t11(){T(custom_threshold_respected);PilotQueueItem i{"j","s",false,0.6};C(!PilotQueuePanelModel::needsHumanReview(i,0.7),"threshold");P();}
void t12(){T(threshold_strictly_greater);PilotQueueItem i{"j","s",false,0.5};C(!PilotQueuePanelModel::needsHumanReview(i,0.5),"strict");P();}
int main(){std::cout<<"Step 661: Pilot queue panel\n";t1();t2();t3();t4();t5();t6();t7();t8();t9();t10();t11();t12();std::cout<<"\nResults: "<<p<<"/"<<(p+f)<<" passed\n";return f?1:0;}

View File

@@ -13625,3 +13625,27 @@ job payload output (`type`, `goal`, `context.files`, `context.entropy_score`,
- `editor/src/InferenceJobGenerator.h` (`32` <= `600`)
- `editor/tests/step660_test.cpp` within test-file size guidance (`24` lines)
- Header-only architecture and naming conventions remain aligned with `ARCHITECTURE.md`
### Step 661: Pilot queue panel
**Status:** PASS (12/12 tests)
Adds pilot-queue review modeling for escalate/ambiguity gating and human
decision actions (`approve`, `reject`, `modify`) with strategy-note support.
**Files added:**
- `editor/src/PilotQueuePanelModel.h` - pilot queue decision model
- `editor/tests/step661_test.cpp` - 12 tests for review and action behavior
**Files modified:**
- `editor/CMakeLists.txt` - `step661_test` target
**Verification run:**
- `cmake -S editor -B editor/build-native` - PASS
- `cmake --build editor/build-native --target step661_test step660_test` - PASS
- `./editor/build-native/step661_test` - PASS (12/12)
- `./editor/build-native/step660_test` - PASS (12/12) regression coverage
**Architecture gate check:**
- `editor/src/PilotQueuePanelModel.h` (`39` <= `600`)
- `editor/tests/step661_test.cpp` within test-file size guidance (`24` lines)
- Header-only architecture and naming conventions remain aligned with `ARCHITECTURE.md`