bill/whetstone_DSL
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Sprint 33: end-of-sprint architecture refactor pass

Browse Source
This commit is contained in:
Bill
2026-02-17 11:32:51 -07:00
parent 89e0d40471
commit 6a82f4439c
5 changed files with 70 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
editor/src/CapabilityDiscoveryPanels.h
View File

@@ -1,6 +1,8 @@
#pragma once
// Step 586: Capability Discovery Panels
#include "ProductizationValidationUtil.h"
#include <algorithm>
#include <map>
#include <string>
@@ -20,8 +22,10 @@ public:
std::string* error) {
if (!error) return false;
error->clear();
if (categoryId.empty()) return fail(error, "category_id_missing");
if (title.empty()) return fail(error, "category_title_missing");
if (!hasRequiredProductIds(categoryId, title)) {
if (categoryId.empty()) return fail(error, "category_id_missing");
return fail(error, "category_title_missing");
}
if (categories_.count(categoryId) != 0) return fail(error, "category_duplicate");
CapabilityCategory c;
c.categoryId = categoryId;

18
editor/src/ProductizationValidationUtil.h Normal file
View File

@@ -0,0 +1,18 @@
#pragma once
// Sprint 33 refactor: shared productization validation helpers
#include <string>
inline bool hasRequiredProductIds(const std::string& a, const std::string& b) {
return !a.empty() && !b.empty();
}
inline bool isValidHexColor7(const std::string& c) {
if (c.size() != 7 || c[0] != '#') return false;
for (size_t i = 1; i < c.size(); ++i) {
const char x = c[i];
const bool hex = (x >= '0' && x <= '9') || (x >= 'a' && x <= 'f') || (x >= 'A' && x <= 'F');
if (!hex) return false;
}
return true;
}

4
editor/src/ValueForwardOnboardingFlow.h
View File

@@ -1,6 +1,8 @@
#pragma once
// Step 584: Value-Forward Onboarding Flow
#include "ProductizationValidationUtil.h"
#include <string>
#include <vector>
@@ -33,7 +35,7 @@ public:
std::string* error) {
if (!state || !error) return false;
error->clear();
if (profileId.empty()) {
if (!hasRequiredProductIds(profileId, "profile")) {
*error = "profile_id_missing";
return false;
}

20
editor/src/WorkflowVisualizationV2.h
View File

@@ -1,6 +1,8 @@
#pragma once
// Step 585: Workflow Visualization 2.0
#include "ProductizationValidationUtil.h"
#include <algorithm>
#include <map>
#include <string>
@@ -40,9 +42,11 @@ public:
std::string* error) {
if (!graph || !error) return false;
error->clear();
if (node.nodeId.empty()) return fail(error, "node_id_missing");
if (node.label.empty()) return fail(error, "node_label_missing");
if (!isValidColor(node.accentColorHex)) return fail(error, "node_color_invalid");
if (!hasRequiredProductIds(node.nodeId, node.label)) {
if (node.nodeId.empty()) return fail(error, "node_id_missing");
return fail(error, "node_label_missing");
}
if (!isValidHexColor7(node.accentColorHex)) return fail(error, "node_color_invalid");
if (findNode(*graph, node.nodeId) != nullptr) return fail(error, "node_duplicate");
graph->nodes.push_back(node);
return true;
@@ -94,16 +98,6 @@ private:
return false;
}
static bool isValidColor(const std::string& c) {
if (c.size() != 7 || c[0] != '#') return false;
for (size_t i = 1; i < c.size(); ++i) {
const char x = c[i];
const bool hex = (x >= '0' && x <= '9') || (x >= 'a' && x <= 'f') || (x >= 'A' && x <= 'F');
if (!hex) return false;
}
return true;
}
static const WorkflowNodeVisual* findNode(const WorkflowVisualizationGraph& graph,
const std::string& nodeId) {
for (const auto& node : graph.nodes) if (node.nodeId == nodeId) return &node;

36
progress.md
View File

@@ -11304,3 +11304,39 @@ operational-hardening readiness into final program-level outcome signals.
- **New tests in this sprint plan:** 112/112 passing
- **Phase 33a (584-588):** 56/56 passing
- **Phase 33b (589-593):** 56/56 passing
### Sprint 33 End Refactor Pass (Architecture Compliance)
**Status:** PASS (112/112 tests revalidated)
Performed a focused post-sprint refactor to centralize repeated productization
validation logic across onboarding/workflow/capability modules.
**Files added:**
- `editor/src/ProductizationValidationUtil.h` - shared productization validation helpers:
- shared non-empty dual-id/title guard
- shared `#RRGGBB` hex-color validation helper
**Files modified:**
- `editor/src/ValueForwardOnboardingFlow.h` - switched onboarding profile validation to shared product-id helper
- `editor/src/WorkflowVisualizationV2.h` - switched node id/label + color validation to shared productization helpers
- `editor/src/CapabilityDiscoveryPanels.h` - switched category id/title validation to shared product-id helper
**Verification run:**
- `cmake --build editor/build-native --target step584_test step585_test step586_test step587_test step588_test step589_test step590_test step591_test step592_test step593_test` - PASS
- `./editor/build-native/step584_test` - PASS (12/12)
- `./editor/build-native/step585_test` - PASS (12/12)
- `./editor/build-native/step586_test` - PASS (12/12)
- `./editor/build-native/step587_test` - PASS (12/12)
- `./editor/build-native/step588_test` - PASS (8/8)
- `./editor/build-native/step589_test` - PASS (12/12)
- `./editor/build-native/step590_test` - PASS (12/12)
- `./editor/build-native/step591_test` - PASS (12/12)
- `./editor/build-native/step592_test` - PASS (12/12)
- `./editor/build-native/step593_test` - PASS (8/8)
**Architecture gate check:**
- `editor/src/ProductizationValidationUtil.h` within header-size limit (`18` <= `600`)
- `editor/src/ValueForwardOnboardingFlow.h` within header-size limit (`107` <= `600`)
- `editor/src/WorkflowVisualizationV2.h` within header-size limit (`112` <= `600`)
- `editor/src/CapabilityDiscoveryPanels.h` within header-size limit (`90` <= `600`)
- Shared validation centralization reduces duplicated product-surface guard logic and remains aligned with `ARCHITECTURE.md`