bill/whetstone_DSL
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Harden completion popup selection bounds

Browse Source
This commit is contained in:
Bill
2026-02-16 18:10:35 -07:00
parent 2d4c29d403
commit 90560be614
2 changed files with 19 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
editor/src/panels/EditorPanel.h
View File

@@ -455,6 +455,7 @@ static void renderEditorPanel(EditorState& state) {
bool popupHovered =
ImGui::IsWindowHovered(ImGuiHoveredFlags_AllowWhenBlockedByPopup);
int maxIndex = std::max(0, (int)filtered.size() - 1);
state.completionSelected = std::max(0, std::min(state.completionSelected, maxIndex));
if (ImGui::IsKeyPressed(ImGuiKey_DownArrow)) {
state.completionSelected = std::min(state.completionSelected + 1, maxIndex);
}
@@ -500,6 +501,9 @@ static void renderEditorPanel(EditorState& state) {
}
if (accept && !filtered.empty()) {
state.completionSelected =
std::max(0, std::min(state.completionSelected,
(int)filtered.size() - 1));
const auto& item = filtered[state.completionSelected];
bool preferred = built.preferredNames.count(item.label) > 0;
if (!preferred) {